Open
Conversation
for more information, see https://pre-commit.ci
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #689 +/- ##
==========================================
+ Coverage 79.87% 83.12% +3.25%
==========================================
Files 48 48
Lines 1873 1885 +12
==========================================
+ Hits 1496 1567 +71
+ Misses 377 318 -59
🚀 New features to boost your workflow:
|
h-mayorquin
commented
Mar 25, 2026
Collaborator
Author
There was a problem hiding this comment.
@bendichter was this added accidentally?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spike times are physical event timestamps representing when action potentials occurred. A spike either happened at a specific time or it didn't, so NaN is never a meaningful value. NaN in spike times typically indicates a conversion bug or array padding that was not cleaned up before writing to NWB.
Unlike other spike time checks that sample the first N elements, this check scans the full array because NaN values can appear at any position in the data.